girineko/dhcpd-pools
1
0
Fork 0
mirror of git://git.code.sf.net/p/dhcpd-pools/code synced 2025-12-16 15:57:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

clean_up: checking errno at exit does not make sense

Browse source 
It seems that at least FreeBSD is setting errno when malloc is
successful. There is a change that other operating systems will
do similar things with same, or other system calls, and this will
invalidate the idea of checking errno at exit.

See also email list thread for further information.

http://lists.freebsd.org/pipermail/freebsd-questions/2011-April/229150.html

Reported-by: Roar Pettersen <rope1968@gmail.com>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2011-04-09 17:38:54 +02:00
parent 5cbe8d07fb
commit f6880ed5f4
2 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/dhcpd-pools.c
View file

@ -205,13 +205,6 @@ int main(int argc, char **argv)
}
free(tmp_ranges);
output_analysis();
/* After fopen in output ioctl does like /dev/null which
* cause ENOTTY, and clean_up will see that without this
* reset. At least linux does this, and possibly some
* other systems. There's a report from FreeBSD 8.0 which
* matches quite well with this symptom. */
if (errno == 25)
errno = 0;
clean_up();
return (EXIT_SUCCESS);

3
src/other.c
View file

@ -77,9 +77,6 @@ void clean_up(void)
{
int ret;
if (errno) {
warn("clean_up: errno (%d) set but not checked in correct place.\nif this is repeatable send strace output as a bug report", errno);
}
/* Just in case there something in buffers */
ret = fflush(stdout);
if (errno || ret) {