girineko/dhcpd-pools
1
0
Fork 0
mirror of git://git.code.sf.net/p/dhcpd-pools/code synced 2025-12-18 08:47:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Arithmetic comparisons to be same way around

Browse source 
In writing arithmetic comparisons, use "<" and "<=" rather than
">" and ">=". For some justification, read this:

http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2011-01-22 12:35:18 +01:00
parent e6c32dbdf9
commit ee35f8bb1f
5 changed files with 37 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/analyze.c
View file

@ -61,7 +61,7 @@ int prepare_data(void)
&rangecomp);
/* Sort backups */
if (num_backups > 0) {
if (0 < num_backups) {
qsort(backups, (size_t) num_backups, sizeof(long int),
&intcomp);
}
@ -81,9 +81,9 @@ int do_counting(void)
/* Walk through ranges */
for (k = 0; k < num_ranges; k++) {
/* Count IPs in use */
for (; range_p->last_ip > leases[i]
for (; leases[i] < range_p->last_ip
&& (unsigned long) i < num_leases; i++) {
if (range_p->first_ip > leases[i]) {
if (leases[i] < range_p->first_ip) {
continue;
}
/* IP with in range */
@ -94,9 +94,9 @@ int do_counting(void)
}
/* Count touched IPs */
for (; range_p->last_ip > touches[j]
for (; touches[j] < range_p->last_ip
&& (unsigned long) j < num_touches; j++) {
if (range_p->first_ip > touches[j]) {
if (touches[j] < range_p->first_ip) {
continue;
}
/* IP with in range */
@ -107,10 +107,10 @@ int do_counting(void)
}
/* Count backup IPs */
if (num_backups > 0) {
for (; range_p->last_ip > backups[m]
if (0 < num_backups) {
for (; backups[m] < range_p->last_ip
&& (unsigned long) m < num_touches; m++) {
if (range_p->first_ip > touches[m]) {
if (touches[m] < range_p->first_ip) {
continue;
}
/* IP with in range */