girineko/dhcpd-pools
1
0
Fork 0
mirror of git://git.code.sf.net/p/dhcpd-pools/code synced 2025-12-16 07:47:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

other: use strftime() to generate date-time string

Browse source 
It is better to use library function to create date-time string than sprintf
various struct tm members.  In same go retire time() call that is obsoleted
by clock_gettime().

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2019-01-04 22:18:53 +00:00
parent 4befdeeb47
commit 48e46e8698
No known key found for this signature in database
GPG key ID: A9553245FDE9B739
1 changed files with 9 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/other.c
View file

@ -551,31 +551,23 @@ void clean_up(struct conf_t *state)
} }
/*! \brief Print a time stamp of a path or now to output file. */ /*! \brief Print a time stamp of a path or now to output file. */
void dp_time_tool(FILE *file, const char *path, int epoch) void dp_time_tool(FILE *file, const char *path, const int epoch)
{ {
time_t t; struct stat st;
/* a file or now */
if (path) {
struct stat st;
if (path)
stat(path, &st); stat(path, &st);
t = st.st_mtime; else
} else clock_gettime(CLOCK_REALTIME, &st.st_mtim);
t = time(NULL);
/* epoc or iso time stamp */
if (epoch) if (epoch)
fprintf(file, "%ld", t); fprintf(file, "%ld", st.st_mtim.tv_sec);
else { else {
char time_stamp[64]; char time_stamp[64];
const time_t mtime = st.st_mtim.tv_sec;
struct tm tm; struct tm tm;
int len;
localtime_r(&t, &tm); localtime_r(&mtime, &tm);
len = snprintf(time_stamp, sizeof(time_stamp), "%4d-%.2d-%.2dT%02d:%02d:%02d", strftime(time_stamp, sizeof(time_stamp), "%FT%T%z", &tm);
tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
tm.tm_hour, tm.tm_min, tm.tm_sec);
strftime(time_stamp + len, sizeof(time_stamp) - len, "%z", &tm);
fprintf(file, "%s", time_stamp); fprintf(file, "%s", time_stamp);
} }
} }