girineko/dhcpd-pools
1
0
Fork 0
mirror of git://git.code.sf.net/p/dhcpd-pools/code synced 2025-12-17 16:26:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

bug: use uint32_t for IP numbers

Browse source 
There where long and unsigned long used for IPs in use which
caused occasional off by one errors. The word occasional should
be read: pretty much every one with large enough configuration
has been affected.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2011-07-08 16:28:22 +02:00
parent 3c1d033a79
commit 1e82461875
5 changed files with 23 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/analyze.c
View file

@ -44,7 +44,7 @@ int prepare_data(void)
unsigned long int i, j, k;
/* Sort leases */
qsort(leases, (size_t) num_leases, sizeof(long int), &intcomp);
qsort(leases, (size_t) num_leases, sizeof(uint32_t), &intcomp);
/* Get rid of lease dublicates */
for (k = j = i = 0; i < num_leases; i++) {
@ -67,7 +67,7 @@ int prepare_data(void)
}
}
num_touches = j;
qsort(touches, (size_t) num_touches, sizeof(long int), &intcomp);
qsort(touches, (size_t) num_touches, sizeof(uint32_t), &intcomp);
/* Sort ranges */
qsort(ranges, (size_t) num_ranges, sizeof(struct range_t),
@ -75,7 +75,7 @@ int prepare_data(void)
/* Sort backups */
if (0 < num_backups) {
qsort(backups, (size_t) num_backups, sizeof(long int),
qsort(backups, (size_t) num_backups, sizeof(uint32_t),
&intcomp);
}